From 29ecce1d79dfae8ad5ef07716b8582c37a823f82 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Tue, 10 Nov 2026 20:18:18 +0100 Subject: fix(perf): NFS shares no longer raise the tile's dot A nearly full file server lit the drawer tile's dot while CPU, RAM and every local disk were fine. Shares stay in the panel with their fill; only local disks count toward the dot. Co-Authored-By: Claude Opus 5.5 --- desktop/modules/perf/Perf.qml | 5 +++-- desktop/modules/perf/README.md | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/desktop/modules/perf/Perf.qml b/desktop/modules/perf/Perf.qml index d165110..5fcf0ab 100644 --- a/desktop/modules/perf/Perf.qml +++ b/desktop/modules/perf/Perf.qml @@ -66,11 +66,12 @@ Singleton { readonly property var ip: P.ipCheck(root.pub, root.now, Prefs.pinnedIp) // The icon's dot. CPU load is left out: spikes would flicker it, and - // sustained load shows up as heat. + // sustained load shows up as heat. NFS shares are too: a full file server + // is shown in the panel, not raised as this PC's trouble. readonly property string severity: P.worst( root.temps.map(t => P.band(t.value, t.warn, t.crit)) .concat([P.band(root.mem ? 100 * root.mem.used / root.mem.total : null, 85, 95)]) - .concat(root.disks.map(d => P.band(d.pct, 90, 95))) + .concat(root.disks.filter(d => !d.host).map(d => P.band(d.pct, 90, 95))) .concat([root.ip.mismatch ? "crit" : "ok"])) readonly property string pubipPath: diff --git a/desktop/modules/perf/README.md b/desktop/modules/perf/README.md index 3d11be4..d5ae0b3 100644 --- a/desktop/modules/perf/README.md +++ b/desktop/modules/perf/README.md @@ -13,10 +13,11 @@ The tile shows CPU and RAM, and a dot for the worst of these, yellow or red: | --- | --- | --- | | each temperature | its warn | its crit | | RAM | 85% | 95% | -| each disk | 90% | 95% | +| each local disk | 90% | 95% | | public IP | | differs from the pinned one | -CPU load is left out, since spikes would flicker it. There is no hysteresis, +CPU load is left out, since spikes would flicker it, and so are NFS shares: +a full file server shows in the panel, not as this PC's trouble. There is no hysteresis, so a sensor sitting on its threshold can toggle the dot. The pin beside the public IP, on the network page, stores the address shown as `perf.pinnedIp` in `$XDG_STATE_HOME/keystone/desktop.json`; the check exists because the VPN -- cgit v1.2.3