From 40328fb336ebcec716a39d1f78cdee95b89bc75b Mon Sep 17 00:00:00 2001
From: "Danilo M." <danix@danix.xyz>
Date: Mon, 14 Sep 2026 14:02:21 +0200
Subject: fix: the Not spam review findings

Close the two Important test gaps and fold in the minor notes.

notSpamIsAbsentOnAReplyRow passed for the wrong reason: the reply node had
no filePath and the selected child was the first message, so the predicate
answered false on the empty path and hid the action with or without the reply
guard. Give the reply a real spam path and select the actual reply child;
mutation-checked that removing the guard now fails the test.

Add notSpamThreadMovesEveryMessageHome, the thread-scoped coverage
notSpamThreads()/m_pendingThreadScope/wholeThreadIds had none of, and assert
the folded thread-scoped trash Restore re-adds the inbox tag.

Rename the label Not junk -> Not spam (no free mnemonic in the Message menu)
to match the rest of the UI, with the Italian translation updated, and add a
changelog line for the thread-scoped Restore inbox-tag fix.
---
 translations/qtmaildir_it_IT.ts | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

(limited to 'translations/qtmaildir_it_IT.ts')

diff --git a/translations/qtmaildir_it_IT.ts b/translations/qtmaildir_it_IT.ts
index dfd2ff9..f4d7688 100644
--- a/translations/qtmaildir_it_IT.ts
+++ b/translations/qtmaildir_it_IT.ts
@@ -549,6 +549,10 @@ Il messaggio È stato inviato. Non inviarlo di nuovo.</translation>
         <source>Add or remove the deleted tag</source>
         <translation>Aggiunge o rimuove l&apos;etichetta deleted</translation>
     </message>
+    <message>
+        <source>Not spam</source>
+        <translation>Non spam</translation>
+    </message>
     <message>
         <source>Remove the unread tag from every message of the selected threads</source>
         <translation>Rimuove il tag unread da ogni messaggio delle conversazioni selezionate</translation>
@@ -769,10 +773,6 @@ Il messaggio È stato inviato. Non inviarlo di nuovo.</translation>
         <source>Empty spam</source>
         <translation>Svuota spam</translation>
     </message>
-    <message>
-        <source>Not junk</source>
-        <translation>Non spam</translation>
-    </message>
     <message>
         <source>Undelete thread</source>
         <translation>Ripristina conversazione</translation>
@@ -927,10 +927,6 @@ Il messaggio È stato inviato. Non inviarlo di nuovo.</translation>
         <source>Move the selected messages to the spam folder</source>
         <translation>Sposta nella cartella spam i messaggi selezionati</translation>
     </message>
-    <message>
-        <source>Not &amp;junk</source>
-        <translation>&amp;Non spam</translation>
-    </message>
     <message>
         <source>Move the selected messages out of the spam folder</source>
         <translation>Sposta fuori dalla cartella spam i messaggi selezionati</translation>
-- 
cgit v1.2.3