From d10a5860b290ee35f657e95e509c8dac7608f809 Mon Sep 17 00:00:00 2001
From: "Danilo M." <danix@danix.xyz>
Date: Thu, 13 Aug 2026 11:26:30 +0200
Subject: feat(rules): load a rule into the builder rows

Selecting a rule now parses its stored query and rebuilds the builder
rows from it, and a row edit compiles back onto the query line and into
the working copy.

Populating the form was already able to write the rule just loaded over
whichever rule is current: m_enabled's toggled runs
applyEditsToCurrentRule while m_query still holds the previous rule's
text, which emptied the first rule's query on open. The existing
m_reloading guard now covers the whole load rather than one signal
blocker on the note, which also covers the combo boxes rebuildRows
populates.
---
 tests/test_tagrules.cpp | 72 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)

(limited to 'tests/test_tagrules.cpp')

diff --git a/tests/test_tagrules.cpp b/tests/test_tagrules.cpp
index 8c7e1a9..fa5c0b5 100644
--- a/tests/test_tagrules.cpp
+++ b/tests/test_tagrules.cpp
@@ -19,7 +19,9 @@
 #include <QTemporaryDir>
 #include <QtTest>
 
+#include "rulequery.h"
 #include "tagrules.h"
+#include "tagrulesdialog.h"
 
 /// The risk in TagRules is the format, not painting: a field silently dropped
 /// on save mis-tags real mail on the next sync, and does it quietly. These
@@ -38,6 +40,8 @@ private slots:
     void aQueryWithQuotesRoundTrips();
     void aMissingFileIsEmptyNotAnError();
     void aNewerVersionIsRefused();
+    void openingARuleFillsTheBuilderRows();
+    void switchingRulesDoesNotLeakRowsBetweenThem();
 
 private:
     QString writeRules(const QString &json);
@@ -241,5 +245,73 @@ void TestTagRules::aNewerVersionIsRefused()
     QCOMPARE(rules.warnings().size(), 1);
 }
 
+void TestTagRules::openingARuleFillsTheBuilderRows()
+{
+    // The dialog reads the shared store from its default path, so point the
+    // whole process at a temporary one. XDG_CONFIG_HOME is what
+    // TagRules::defaultPath() honours.
+    QTemporaryDir configHome;
+    QVERIFY(configHome.isValid());
+    qputenv("XDG_CONFIG_HOME", configHome.path().toUtf8());
+    QVERIFY(QDir().mkpath(configHome.filePath(QStringLiteral("mailrules"))));
+
+    QFile out(configHome.filePath(QStringLiteral("mailrules/rules.json")));
+    QVERIFY(out.open(QIODevice::WriteOnly));
+    out.write(R"({
+      "version": 1,
+      "rules": [
+        {"id": "vendor",
+         "query": "from:vendor.example.org and subject:receipt",
+         "add": ["vendor"], "stage": 50, "enabled": true}
+      ]
+    })");
+    out.close();
+
+    TagRulesDialog dialog;
+
+    QCOMPARE(dialog.rowCountForTest(), 2);
+    QCOMPARE(dialog.queryLineForTest(),
+             QStringLiteral("from:vendor.example.org and subject:receipt"));
+}
+
+void TestTagRules::switchingRulesDoesNotLeakRowsBetweenThem()
+{
+    QTemporaryDir configHome;
+    QVERIFY(configHome.isValid());
+    qputenv("XDG_CONFIG_HOME", configHome.path().toUtf8());
+    QVERIFY(QDir().mkpath(configHome.filePath(QStringLiteral("mailrules"))));
+
+    QFile out(configHome.filePath(QStringLiteral("mailrules/rules.json")));
+    QVERIFY(out.open(QIODevice::WriteOnly));
+    out.write(R"({
+      "version": 1,
+      "rules": [
+        {"id": "one", "query": "from:one.example.org",
+         "add": ["one"], "stage": 50, "enabled": true},
+        {"id": "two",
+         "query": "from:two.example.org or from:three.example.org",
+         "add": ["two"], "stage": 50, "enabled": true}
+      ]
+    })");
+    out.close();
+
+    TagRulesDialog dialog;
+
+    // The first rule is selected on open: one row, joined All by default.
+    QCOMPARE(dialog.rowCountForTest(), 1);
+    QCOMPARE(dialog.queryLineForTest(), QStringLiteral("from:one.example.org"));
+
+    dialog.selectRuleForTest(1);
+    QCOMPARE(dialog.rowCountForTest(), 2);
+    QCOMPARE(dialog.queryLineForTest(),
+             QStringLiteral("from:two.example.org or from:three.example.org"));
+
+    // And back, to prove the first rule was not overwritten by loading the
+    // second.
+    dialog.selectRuleForTest(0);
+    QCOMPARE(dialog.rowCountForTest(), 1);
+    QCOMPARE(dialog.queryLineForTest(), QStringLiteral("from:one.example.org"));
+}
+
 QTEST_MAIN(TestTagRules)
 #include "test_tagrules.moc"
-- 
cgit v1.2.3