From fe5703419f2ac2a5e619b3d527530a71a9a9499e Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Thu, 13 Aug 2026 11:03:38 +0200 Subject: docs,rulequery: state the tag quoting rule rather than the test The draft compile() quoted every Is/IsNot term, which contradicted the same task's own assertion that a negated tag compiles to . The implementer resolved it in the direction the tests specify, and the resolution is right: notmuch reads tag:inbox and tag:"inbox" identically, counting 5322 either way against the live index, so quoting a tag would change the stored string without changing what it matches. That breaks the byte-for-byte round trip this type exists to guarantee. Restate the comment as the rule rather than as a note about what a test expects, correct the plan's draft so the remaining tasks do not inherit the contradiction, and warn the parser task that a quoted tag must not be read back as a quoting operator. --- src/rulequery.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'src/rulequery.cpp') diff --git a/src/rulequery.cpp b/src/rulequery.cpp index 198c583..9b79b2b 100644 --- a/src/rulequery.cpp +++ b/src/rulequery.cpp @@ -51,10 +51,13 @@ bool needsQuotes(const RuleTerm &term) return true; if (term.value.contains(QLatin1Char(' '))) return true; - // Is/IsNot asks for an exact phrase, which only free-text fields need - // quoting for: tag: and attachment: values are already bare words, and - // quoting them changes nothing notmuch cares about but breaks the test's - // documented expectation of an unquoted tag. + // Is/IsNot means an exact phrase, and only the free-text fields need + // quotes to express one. A tag or an attachment name is a single bare + // token to notmuch, which reads `tag:inbox` and `tag:"inbox"` identically + // (both count 5322 against the live index). Quoting them would therefore + // change the stored string without changing what it matches, and this + // type's whole contract is that an unedited rule compiles back byte for + // byte. if (term.op == RuleTerm::Is || term.op == RuleTerm::IsNot) { return term.field == RuleTerm::From || term.field == RuleTerm::To || term.field == RuleTerm::Cc || term.field == RuleTerm::Subject; -- cgit v1.2.3