From a00d35452fcef8c8bc723ba7045fcae38fe8f315 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Mon, 7 Sep 2026 10:12:10 +0200 Subject: fix: refresh the current query when the index changes Item 192's second half, answered by the user: indexing is not repainting. The sent copy became findable the moment it was sent and a Sent view already on screen still did not show it, because nothing re-ran the query. The model cannot insert the row optimistically either, since item 170's constraint applies: the query never returned that thread. NotmuchWorker::indexChanged() is emitted at the end of both indexDraftFile() and removeIndexedFile(), the only two entry points that change what a path query would return without any query having run. MainWindow connects it to refreshCurrentQuery(), which covers all three gestures a path view can miss: a sent copy indexed, a draft saved, a draft's entry dropped on send. Wiring only the indexing half would have left a ghost draft row visible in a Drafts view after a send. The signal carries nothing, so it cannot invite an optimistic insert. It is emitted after the database closes, so a refresh reaching notmuch on the next turn of the event loop cannot race the write handle. refreshCurrentQuery() rather than runCurrentQuery(): a send must not clear the selection, the expansions or the undo stack of the window behind the composer. aSentMessageAppearsInASentViewAlreadyOnScreen drives a real send through a worker-backed window, asserts the Sent view is empty first, and asserts the row arrives with no second returnPressed() and no sync. Mutation-checked by disabling the connection. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01FWeBw3UqxpBktSc1AkZ6ir --- src/notmuchworker.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'src/notmuchworker.h') diff --git a/src/notmuchworker.h b/src/notmuchworker.h index a0c8feb..32eab58 100644 --- a/src/notmuchworker.h +++ b/src/notmuchworker.h @@ -351,6 +351,21 @@ signals: void threadDigestLoaded(const ThreadDigest &digest, quint64 generation); void tagsApplied(const TagChange &change); + /// One file entered or left the index outside a query (item 192). + /// + /// Emitted by indexDraftFile() and removeIndexedFile(), the two entry + /// points that change what a path query would return without any query + /// having run. A view built on such a query, Sent and Drafts both, is + /// stale the moment either fires: indexing a sent copy is what makes the + /// message findable, and MainWindow refreshes on this so the view the user + /// is looking at gains the row rather than waiting for the next sync. + /// + /// Carries nothing. The refresh re-runs the whole query, so which file + /// moved is not the UI's question; a payload would only invite an + /// optimistic insert, which item 170 rules out for a thread the query + /// never returned. + void indexChanged(); + /// Carries the ids that ACTUALLY moved, which may be fewer than requested. /// A stale id, a missing folder or a failed rename drops out here rather /// than aborting the batch. -- cgit v1.2.3