From c4a38a5871250b9c952f3eb633ab4cf2ed3d717a Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Tue, 29 Sep 2026 17:58:07 +0200 Subject: fix: accept a bracketed Message-ID in the message selector A Message-ID is written in every header a caller copies it from, and notmuch stores it without the angle brackets, so `--message ''`, the form the README itself shows, matched nothing and was reported as a miss. applySelectors() now trims the value and strips one enclosing pair of brackets before anything else sees it, so the worker's resolve and the recovery's selection target both use the bare id. Stripping for the resolve alone would open the right thread and then fail to select the message inside it, which is why the test targets a reply rather than a thread root. No refusal of a slashed id was added: notmuch 0.39 reads `/.../` as a regex for mid: but not for id:, measured as 0 matches for id:"/.*/" on an index where mid:"/.*/" matches every message. Co-Authored-By: Claude Opus 5.5 --- src/mainwindow.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainwindow.h') diff --git a/src/mainwindow.h b/src/mainwindow.h index 6b841fa..8167e74 100644 --- a/src/mainwindow.h +++ b/src/mainwindow.h @@ -151,7 +151,7 @@ public: /// A thread id that is not hex is such a miss and never reaches notmuch: /// recoverStaleThread() builds `thread:` unquoted, which is safe for /// ids notmuch handed out and not for ones from another program's argv. - void applySelectors(const LaunchSelectors &selectors); + void applySelectors(const LaunchSelectors &requested); /// Opens the list behind the unsynced-changes count. /// -- cgit v1.2.3