From dd6f35b8f35f231ebf1511daef3dd707eaa9839d Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Mon, 24 Aug 2026 11:02:08 +0200 Subject: fix(compose): default to quoting below, and focus the body on a reply The previous commit fixed the cursor within each quote_position branch and the user still saw the old layout, because the branches were already right: what was wrong was the DEFAULT. quote_position shipped as `above`, and the layout asked for is exactly what `below` already produced, a blank line at the top with the quote underneath. So the default flips, along with the fallback for a malformed value and the warning naming it. Nothing needs an Upgrading note: compose has not been released, so no config in the wild sets this. Focus goes to the body whenever To: is already filled, which a Reply and a Forward always are. The form's first widget took it otherwise, so the user had to click into the editor before typing. A New message keeps the default, since an empty To: is genuinely the first thing to fill in. The focus test asserts on the window's focusWidget() rather than on QWidget::hasFocus(): an unshown window is never active, so hasFocus() reads false whatever the code does and would fail against a correct fix. Both directions are mutation-checked, since focusing unconditionally passes the reply case while breaking the new-message one. --- src/composewindow.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src/composewindow.cpp') diff --git a/src/composewindow.cpp b/src/composewindow.cpp index 59eaccc..1c9b492 100644 --- a/src/composewindow.cpp +++ b/src/composewindow.cpp @@ -143,6 +143,14 @@ ComposeWindow::ComposeWindow(const ComposeContext &context, // as the flag cleared, since markDirty() started it. m_dirty = false; m_autosaveTimer->stop(); + + // The body, whenever there is already a recipient: a Reply or a Forward + // has To: filled in from the context, so the first widget in the form + // would take focus and the user would have to click into the editor + // before typing. A New message keeps the default, since To: is empty and + // is genuinely the first thing to fill in. + if (!m_to->text().trimmed().isEmpty()) + m_body->setFocus(); } -- cgit v1.2.3