From 8031901652758e9db5ef0bb545c062f80f2f8cc2 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Mon, 10 Aug 2026 09:35:29 +0200 Subject: docs: close items 20, 51, 53 and 60, now that the card list is on master Three passages claimed the code was not on master, which stopped being true at the merge. The distinction worth keeping is which branch a reference points at: item 20's file and line references still mean `item-20-message-rows` at 029a50e, kept unmerged as the record of the presentation the user rejected, while master carries the card list built on top of it. --- .../plans/2026-08-03-post-0.1.0-usability.md | 42 +++++++++++----------- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md index ad6dbc0..ae33e19 100644 --- a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md +++ b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md @@ -26,14 +26,13 @@ Numbering is stable. New items append with the next free number and never renumber, so a note referring to "item 7" keeps meaning the same thing. An item that is dropped stays in the table marked `dropped` with a one-line reason. -**One item's code is not on master.** Item 20 was built in full on the branch -`item-20-message-rows` (pushed, not merged) and parked: the user wants to -explore a layout other than the table before deciding. This document and the -plan beside it were brought onto master on purpose, so the backlog reads -correctly at session start, but master has none of that code. Any file and line -reference in items 20 and 53 points at the BRANCH. Item 53 is where the -reservation and the four possible directions live; read it before touching -either. +**Items 20 and 53 are both on master since 2026-08-10**, as the card list. Item +20's original presentation, the one the user rejected on sight, is preserved on +the branch `item-20-message-rows` at 029a50e and was never merged; the branch +`card-list` carries the work that was. Any file or line reference in item 20's +entry below points at that PARKED branch, not at master, where the same lines +are unrelated. Item 53 records why the first attempt was rejected and is worth +reading before changing the thread pane again. ## Theme @@ -77,7 +76,7 @@ taking that too literally. | 17 | No completion for tags in the query bar | workflow | M | **done** | | 18 | No visual cue that there are unsynced edits | feedback | S | **done** | | 19 | No prompt to sync on exit when edits are pending | behavior | S | **done** | -| 20 | Thread view does not match the user's mental model | presentation | L | rebuilt as cards on branch `card-list`, **not merged**; awaiting the user's verdict | +| 20 | Thread view does not match the user's mental model | presentation | L | **done** 2026-08-10, as the card list; see 53 | | 21 | Default shortcuts are not sensible enough | discoverability | S | open | | 22 | Translatability audit and i18n wiring | correctness | M | open | | 23 | No way to save a search query from the UI | workflow | M | open | @@ -108,16 +107,16 @@ taking that too literally. | 48 | Removing a tag suggests every tag, not the thread's own | workflow | XS | **done** | | 49 | Sync runs every account regardless of what changed | workflow | M | **done** | | 50 | Esc blanks the pane but leaves the row selected | workflow | XS | **done** | -| 51 | Clicking a subject scrolls the list sideways | presentation | XS | built on branch `card-list`, **not merged**; a card is viewport width | +| 51 | Clicking a subject scrolls the list sideways | presentation | XS | **done** 2026-08-10; a card is viewport width, so there is nowhere to scroll | | 52 | `test_querycompleter` fails under Wayland, passes offscreen | testing | XS | **done** | -| 53 | Message rows still read as a table, not as a conversation | presentation | M | built 2026-08-10 on branch `card-list`, **not merged**; awaiting the user's verdict | +| 53 | Message rows still read as a table, not as a conversation | presentation | M | **done** 2026-08-10, merged to master as the card list | | 54 | A cron sync carries the edits but the count still says pending | correctness | S | **done** | | 55 | In a narrow window the message pane is invisible | presentation | XS | **done** | | 56 | No action carries an icon, so the toolbar reserves space for nothing | presentation | S | **done** | | 57 | "Flag" would read better as "Important" or "Starred" | presentation | XS | **done** | | 58 | `message_zoom` documents a 0.5 to 3.0 range and enforces none of it | correctness | XS | **done** | | 59 | Archive and Mark all read shipped with the same icon | presentation | XS | **done** | -| 60 | Next thread dead-ends on the last reply of an expanded thread | defect | XS | **done** on the branch; already fixed by 5487d58, see below | +| 60 | Next thread dead-ends on the last reply of an expanded thread | defect | XS | **done**; already fixed by 5487d58, see below | Sizes are rough: XS under an hour, S a sitting, M a session. @@ -1255,14 +1254,17 @@ is centralised rather than smeared across call sites. warrant a feature branch (`item-20-message-rows`, 2026-08-08). It is a left-pane model and view replacement plus a selection-scope change, not a refactor. -**Built 2026-08-08 across ten tasks, on the branch `item-20-message-rows` and -NOT merged.** master carries these documents and none of the code, deliberately: -the user parked the branch to explore a different layout first. Read item 53 -before reviving it. All four decisions were implemented: message -rows in the left pane, the root row as the thread's first message, replies -indented by depth, action scope following the selected row kind and named in the -status bar. 15 test binaries green, 65 tests in `test_mainwindow` alone, ten -mutation checks. +**Built 2026-08-08 across ten tasks, on the branch `item-20-message-rows`, and +rejected on sight.** All four decisions were implemented: message rows in the +left pane, the root row as the thread's first message, replies indented by +depth, action scope following the selected row kind and named in the status bar. +15 test binaries green, 65 tests in `test_mainwindow` alone, ten mutation checks. + +**That branch was never merged and is kept at 029a50e as the record of the +rejected presentation.** What reached master on 2026-08-10 is the card list, +built on top of it: the model, the reply walk and `MessageNode` survived intact, +and the five-column grid they were drawn into did not. Read item 53 for the +diagnosis. **The user's verdict on the result: not convinced it fits.** Recorded here rather than in a commit message, because the item shipped working and the -- cgit v1.2.3