From aa10536a548032f861a860406c3106e123048d37 Mon Sep 17 00:00:00 2001
From: "Danilo M." <danix@danix.xyz>
Date: Wed, 12 Aug 2026 11:28:54 +0200
Subject: feat(rules): drop a malformed rule rather than the whole file

One typo must not stop the other rules from tagging. A missing file and
a file that will not parse are tracked separately: the hook may run on
the first and must refuse on the second.
---
 test_mailrules.py | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)

(limited to 'test_mailrules.py')

diff --git a/test_mailrules.py b/test_mailrules.py
index dd491e9..f349f05 100755
--- a/test_mailrules.py
+++ b/test_mailrules.py
@@ -82,6 +82,78 @@ def test_defaults_are_applied():
         assert rule.note == ""
 
 
+def test_a_bad_rule_is_dropped_and_the_rest_survive():
+    """One malformed rule must not stop the others. The hook runs every ten
+    minutes on real mail; losing all tagging because of one typo is worse
+    than losing one rule."""
+    with tempfile.TemporaryDirectory() as tmp:
+        path = write_rules(tmp, {
+            "version": 1,
+            "rules": [
+                {"id": "good", "add": ["x"], "query": "from:a@example.com"},
+                {"id": "no-query", "add": ["y"]},
+                {"id": "no-tags", "query": "from:b@example.com"},
+                {"id": "bad id!", "add": ["z"], "query": "from:c@example.com"},
+                {"add": ["w"], "query": "from:d@example.com"},
+            ],
+        })
+        store = mailrules.load(path)
+        assert [r.id for r in store.rules] == ["good"]
+        assert len(store.warnings) == 4, store.warnings
+        joined = " ".join(store.warnings)
+        assert "no-query" in joined
+        assert "no-tags" in joined
+        assert "bad id!" in joined
+
+
+def test_duplicate_ids_keep_the_first():
+    with tempfile.TemporaryDirectory() as tmp:
+        path = write_rules(tmp, {
+            "version": 1,
+            "rules": [
+                {"id": "dup", "add": ["first"], "query": "from:a@example.com"},
+                {"id": "dup", "add": ["second"], "query": "from:b@example.com"},
+            ],
+        })
+        store = mailrules.load(path)
+        assert len(store.rules) == 1
+        assert store.rules[0].add == ["first"]
+        assert any("dup" in w for w in store.warnings)
+
+
+def test_a_missing_file_is_empty_not_an_error():
+    """qtmaildir must open on a machine that has never written this file."""
+    with tempfile.TemporaryDirectory() as tmp:
+        store = mailrules.load(Path(tmp) / "absent.json")
+        assert store.rules == []
+        assert store.warnings == []
+        assert store.missing is True
+
+
+def test_unparseable_json_warns_and_yields_no_rules():
+    with tempfile.TemporaryDirectory() as tmp:
+        path = Path(tmp) / "rules.json"
+        path.write_text("{not json")
+        store = mailrules.load(path)
+        assert store.rules == []
+        assert len(store.warnings) == 1
+        assert store.failed is True
+
+
+def test_a_newer_format_version_is_refused():
+    """Guessing at semantics a later version defined is how a rule silently
+    changes meaning. Refuse instead."""
+    with tempfile.TemporaryDirectory() as tmp:
+        path = write_rules(tmp, {
+            "version": 2,
+            "rules": [{"id": "x", "add": ["a"], "query": "from:a@example.com"}],
+        })
+        store = mailrules.load(path)
+        assert store.rules == []
+        assert store.failed is True
+        assert any("version" in w for w in store.warnings)
+
+
 def run_all():
     for name, fn in sorted(globals().items()):
         if name.startswith("test_") and callable(fn):
-- 
cgit v1.2.3