From 37e2b3d9da2297e18431b4dd9e21170aff673b3e Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Sun, 9 Aug 2026 14:56:59 +0200 Subject: docs: stop crediting from None with secret hygiene A TimeoutExpired chained without from None already prints no secret, since its __str__ shows only the command and the duration. The suppressed display buys a tidier traceback, not a narrower leak, and the comments claimed otherwise. The from None calls stay. Co-Authored-By: Claude Opus 5 --- test_llamachat.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'test_llamachat.py') diff --git a/test_llamachat.py b/test_llamachat.py index 5ee2310..b943976 100755 --- a/test_llamachat.py +++ b/test_llamachat.py @@ -1154,8 +1154,9 @@ def test_key_resolution(): assert "gpg-agent" in str(exc) # The partial stdout a timeout captures must never reach the message. assert "partial-secret" not in str(exc) - # `from None` suppresses the chained traceback. It does not clear - # __context__, so this pins the display behavior, not unreachability. + # `from None` suppresses the chained-traceback display. It does not + # clear __context__, and the chained traceback would not have shown + # the secret anyway, so this pins tidiness, not secret hygiene. assert exc.__suppress_context__ and exc.__cause__ is None # A non-zero exit quotes gpg's stderr, which is the only useful part, and -- cgit v1.2.3