From b2517c9270382794b3ec5be73201590b4127d553 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Fri, 17 Jul 2026 11:28:26 +0200 Subject: fix: send User-Agent to avoid Cloudflare 403 on sun API sunrise-sunset.org sits behind Cloudflare, which rejects the default Python-urllib User-Agent with 403 (error 1010). Send a normal UA in _http_get so fetch_sun and geolocate get through. Co-Authored-By: Claude Opus 4.8 --- tests/test_sun.py | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) (limited to 'tests/test_sun.py') diff --git a/tests/test_sun.py b/tests/test_sun.py index 4e15cb2..033dd26 100644 --- a/tests/test_sun.py +++ b/tests/test_sun.py @@ -1,8 +1,8 @@ import json from datetime import timezone from zoneinfo import ZoneInfo -from unittest.mock import patch -from hyprsunset_qt.sun import to_local_hm, read_cache, write_cache, geolocate, fetch_sun +from unittest.mock import patch, MagicMock +from hyprsunset_qt.sun import to_local_hm, read_cache, write_cache, geolocate, fetch_sun, _http_get def test_utc_to_local_hm(): @@ -22,6 +22,21 @@ def test_read_cache_missing(tmp_path): assert read_cache(tmp_path / "nope.json") is None +def test_http_get_sends_user_agent(): + # sunrise-sunset.org sits behind Cloudflare, which 403s the default + # Python-urllib User-Agent (error 1010). _http_get must send a real UA. + resp = MagicMock() + resp.read.return_value = b"{}" + resp.__enter__.return_value = resp + resp.__exit__.return_value = False + with patch("hyprsunset_qt.sun.urllib.request.urlopen", return_value=resp) as uo: + _http_get("https://example.com/x") + req = uo.call_args[0][0] + # urlopen was called with a Request carrying a non-default User-Agent + assert req.get_header("User-agent") + assert "urllib" not in req.get_header("User-agent").lower() + + def test_geolocate_parses_latlon(): body = json.dumps({"status": "success", "lat": 45.07, "lon": 7.68}) with patch("hyprsunset_qt.sun._http_get", return_value=body): -- cgit v1.2.3