From 460cd4456790092ea42a8848bb0ea517a1174fca Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Fri, 16 Oct 2026 13:31:42 +0200 Subject: Final review: startup probe, error messages, refusal exit, docs A startup probe that failed with anything but OSError (llama-server not in router mode, an empty model list) crashed the daemon at boot, against its own comment; it is caught like the per-request failures now. llama-server's reasons reach the client: an HTTP error carries its body and an error chunk mid-stream its message, where the client used to see 'choices'. A daemon that refuses to start, or fails before serving, exits 1 instead of 0. assistant.sh no longer mistakes a --test run for the daemon. AGENTS.md said every section from Hardware to Kokoro was voice-only, which included findings the daemon still applies; it now names the voice ones. It also claimed a stopped reply emits nothing after done, while a late ctx can. The spec lists every error message, the example config no longer shows a non-default temperature as the default, and the updates tool stops telling the model not to read lists aloud. The spec is marked implemented. Co-Authored-By: Claude Opus 5.5 --- assistant.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'assistant.sh') diff --git a/assistant.sh b/assistant.sh index 315829e..30216dd 100755 --- a/assistant.sh +++ b/assistant.sh @@ -27,7 +27,7 @@ set -eu dir=$(cd "$(dirname "$0")" && pwd) log="${XDG_RUNTIME_DIR:?not in a login session}/desktop-assistant.log" -pat='^\S*python3 (-u )?\S*assistant\.py' +pat='^\S*python3 (-u )?\S*assistant\.py$' # not a --test run kill_wait() { pkill -u "$USER" -f "$1" || return 0 -- cgit v1.2.3