From 244fd92f8b59aeca608253e87bb7a7076ca4a960 Mon Sep 17 00:00:00 2001 From: Aditya Wasan Date: Wed, 7 Sep 2022 17:49:08 -0400 Subject: Use `GENERAL_SHOW_TIME` for decryption screen timeout (#2107) * feat(app): use `GENERAL_SHOW_TIME` for decryption screen as well Signed-off-by: Aditya Wasan * feat: update timeout to 60 seconds Signed-off-by: Aditya Wasan * refactor(app): use constant instead of using a magic number Signed-off-by: Aditya Wasan * Add changelog entry Signed-off-by: Aditya Wasan Co-authored-by: Harsh Shandilya --- detekt-baselines/app.xml | 1 - detekt-baselines/crypto-pgpainless.xml | 1 - 2 files changed, 2 deletions(-) (limited to 'detekt-baselines') diff --git a/detekt-baselines/app.xml b/detekt-baselines/app.xml index a82c325e..cbbe4a17 100644 --- a/detekt-baselines/app.xml +++ b/detekt-baselines/app.xml @@ -35,7 +35,6 @@ LongMethod:RepositorySettings.kt$RepositorySettings$override fun provideSettings(builder: PreferenceScreen.Builder) LoopWithTooManyJumpStatements:AutofillMatcher.kt$AutofillMatcher.Companion$for ((key, value) in prefs.all) { if (!key.startsWith(PREFERENCE_PREFIX_MATCHES)) continue // We know that preferences starting with `PREFERENCE_PREFIX_MATCHES` were // created with `putStringSet`. @Suppress("UNCHECKED_CAST") val oldMatches = value as? Set<String> if (oldMatches == null) { logcat(WARN) { "Failed to read matches for $key" } continue } // Delete all matches for file locations that are going to be overwritten, then // transfer matches over to the files at their new locations. val newMatches = oldMatches .asSequence() .minus(deletePathList) .minus(oldNewPathMap.values) .map { match -> val newPath = oldNewPathMap[match] ?: return@map match logcat { "Updating match for $key: $match --> $newPath" } newPath } .toSet() if (newMatches != oldMatches) prefs.edit { putStringSet(key, newMatches) } } LoopWithTooManyJumpStatements:ErrorMessages.kt$ErrorMessages$while (cause.cause != null) { if (cause is GitException) break val nextCause = cause.cause!! if (nextCause is RemoteException) break cause = nextCause } - MagicNumber:BasePgpActivity.kt$BasePgpActivity$45 MagicNumber:ClipboardService.kt$ClipboardService$1000 MagicNumber:ClipboardService.kt$ClipboardService$1000L MagicNumber:ClipboardService.kt$ClipboardService$45 diff --git a/detekt-baselines/crypto-pgpainless.xml b/detekt-baselines/crypto-pgpainless.xml index 5f6cad27..0276df1b 100644 --- a/detekt-baselines/crypto-pgpainless.xml +++ b/detekt-baselines/crypto-pgpainless.xml @@ -10,6 +10,5 @@ MagicNumber:GpgIdentifier.kt$GpgIdentifier.KeyId$8 NestedBlockDepth:GpgIdentifier.kt$GpgIdentifier.Companion$private fun splitUserId(userId: String): String? ReturnCount:GpgIdentifier.kt$GpgIdentifier.Companion$public fun fromString(identifier: String): GpgIdentifier? - ReturnCount:KeyUtils.kt$KeyUtils$public fun tryParseKeyring(key: PGPKey): PGPKeyRing? -- cgit v1.2.3