From 73058d10a8e28fe4e7636ad5c73eeb8651369cdb Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <msfjarvis@gmail.com>
Date: Thu, 5 Mar 2020 21:05:50 +0530
Subject: Resolve various memory leaks (#637)

This migrates the clipboard clear logic into a foreground service that allows us to also provide a notification that runs the clear task immediately on click, rather than wait for the timeout.

Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
---
 app/src/main/res/layout/decrypt_layout.xml | 10 ----------
 app/src/main/res/values/strings.xml        |  2 +-
 2 files changed, 1 insertion(+), 11 deletions(-)

(limited to 'app/src/main/res')

diff --git a/app/src/main/res/layout/decrypt_layout.xml b/app/src/main/res/layout/decrypt_layout.xml
index 17ab55ed..8f8198a4 100644
--- a/app/src/main/res/layout/decrypt_layout.xml
+++ b/app/src/main/res/layout/decrypt_layout.xml
@@ -94,16 +94,6 @@
                 app:layout_constraintBaseline_toBaselineOf="@id/crypto_password_show_label"
                 android:typeface="monospace" />
 
-            <ProgressBar
-                android:id="@+id/pbLoading"
-                style="?android:attr/progressBarStyleHorizontal"
-                android:layout_width="match_parent"
-                android:layout_height="8dp"
-                android:layout_marginBottom="8dp"
-                android:visibility="invisible"
-                android:layout_marginTop="8dp"
-                app:layout_constraintTop_toBottomOf="@id/crypto_password_show_label"/>
-
             <com.google.android.material.button.MaterialButton
                 style="@style/Widget.MaterialComponents.Button"
                 android:id="@+id/crypto_password_toggle_show"
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index b244a877..b605b9be 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -305,5 +305,5 @@
     <string name="pref_search_from_root">Always search from root</string>
     <string name="pref_search_from_root_hint">Search from root of store regardless of currently open directory</string>
     <string name="password_generator_category_title">Password Generator</string>
-
+    <string name="tap_clear_clipboard">Tap here to clear clipboard</string>
 </resources>
-- 
cgit v1.2.3