From bc463f3c64ab04ae766aa2f161cce8d5f0e4b9f3 Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <msfjarvis@gmail.com>
Date: Sun, 29 Mar 2020 20:03:50 +0530
Subject: Significantly improve app theming (#679)

* Update CHANGELOG

* Use outlined box style in folder creation dialog

* Add user-facing choice for app theme

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
---
 app/src/main/res/layout/activity_git_clone.xml              | 10 ----------
 app/src/main/res/layout/activity_git_config.xml             |  4 ----
 app/src/main/res/layout/activity_oreo_autofill_filter.xml   |  1 -
 app/src/main/res/layout/encrypt_layout.xml                  |  6 ------
 app/src/main/res/layout/folder_creation_dialog_fragment.xml |  4 +---
 app/src/main/res/layout/fragment_autofill.xml               |  3 +--
 app/src/main/res/layout/fragment_ssh_keygen.xml             |  8 ++------
 7 files changed, 4 insertions(+), 32 deletions(-)

(limited to 'app/src/main/res/layout')

diff --git a/app/src/main/res/layout/activity_git_clone.xml b/app/src/main/res/layout/activity_git_clone.xml
index 2969819e..05d9a557 100644
--- a/app/src/main/res/layout/activity_git_clone.xml
+++ b/app/src/main/res/layout/activity_git_clone.xml
@@ -37,13 +37,11 @@
         app:layout_constraintStart_toEndOf="@id/label_server_protocol" />
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/server_user_layout"
         android:hint="@string/server_user"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
-        app:hintEnabled="true"
         app:layout_constraintTop_toBottomOf="@id/label_server_protocol">
         <com.google.android.material.textfield.TextInputEditText
             android:id="@+id/server_user"
@@ -53,13 +51,11 @@
     </com.google.android.material.textfield.TextInputLayout>
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/label_server_url"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
         android:hint="@string/server_url"
-        app:hintEnabled="true"
         app:layout_constraintTop_toBottomOf="@id/server_user_layout"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toStartOf="@id/label_server_port">
@@ -73,13 +69,11 @@
     </com.google.android.material.textfield.TextInputLayout>
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/label_server_port"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
         android:hint="@string/server_port_hint"
-        app:hintEnabled="true"
         app:layout_constraintStart_toEndOf="@id/label_server_url"
         app:layout_constraintTop_toBottomOf="@id/server_user_layout"
         app:layout_constraintEnd_toEndOf="parent"
@@ -94,13 +88,11 @@
     </com.google.android.material.textfield.TextInputLayout>
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/label_server_path"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
         android:hint="@string/server_path"
-        app:hintEnabled="true"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/label_server_url">
 
@@ -113,14 +105,12 @@
     </com.google.android.material.textfield.TextInputLayout>
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/label_clone_uri"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:hint="@string/repository_uri"
         android:editable="false"
         android:layout_margin="8dp"
-        app:hintEnabled="true"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/label_server_path">
 
diff --git a/app/src/main/res/layout/activity_git_config.xml b/app/src/main/res/layout/activity_git_config.xml
index bb2eac8b..a576ec46 100644
--- a/app/src/main/res/layout/activity_git_config.xml
+++ b/app/src/main/res/layout/activity_git_config.xml
@@ -11,12 +11,10 @@
 
     <com.google.android.material.textfield.TextInputLayout
         android:id="@+id/username_input_layout"
-        style="@style/TextInputLayoutBase"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
         android:hint="@string/git_user_name_hint"
-        app:hintEnabled="true"
         app:layout_constraintTop_toTopOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         tools:layout_editor_absoluteY="64dp">
@@ -30,13 +28,11 @@
     </com.google.android.material.textfield.TextInputLayout>
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/email_input_layout"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
         android:hint="@string/git_user_email"
-        app:hintEnabled="true"
         app:layout_constraintTop_toBottomOf="@id/username_input_layout"
         app:layout_constraintStart_toStartOf="parent">
 
diff --git a/app/src/main/res/layout/activity_oreo_autofill_filter.xml b/app/src/main/res/layout/activity_oreo_autofill_filter.xml
index 17eb0e29..fb745afc 100644
--- a/app/src/main/res/layout/activity_oreo_autofill_filter.xml
+++ b/app/src/main/res/layout/activity_oreo_autofill_filter.xml
@@ -22,7 +22,6 @@
 
     <com.google.android.material.textfield.TextInputLayout
         android:id="@+id/searchLayout"
-        style="@style/TextInputLayoutBase"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginStart="@dimen/activity_horizontal_margin"
diff --git a/app/src/main/res/layout/encrypt_layout.xml b/app/src/main/res/layout/encrypt_layout.xml
index e4d9464a..54b1c7c9 100644
--- a/app/src/main/res/layout/encrypt_layout.xml
+++ b/app/src/main/res/layout/encrypt_layout.xml
@@ -22,14 +22,12 @@
         tools:text="CATEGORY HERE" />
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/name_input_layout"
         android:layout_gravity="center_vertical"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
         android:hint="@string/crypto_name_hint"
-        app:hintEnabled="true"
         app:layout_constraintTop_toBottomOf="@id/crypto_password_category"
         app:layout_constraintStart_toStartOf="parent">
         <com.google.android.material.textfield.TextInputEditText
@@ -39,14 +37,12 @@
     </com.google.android.material.textfield.TextInputLayout>
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/password_input_layout"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
         android:hint="@string/crypto_pass_label"
         app:endIconMode="password_toggle"
-        app:hintEnabled="true"
         app:layout_constraintTop_toBottomOf="@id/name_input_layout"
         app:layout_constraintStart_toStartOf="parent">
         <com.google.android.material.textfield.TextInputEditText
@@ -69,13 +65,11 @@
         app:layout_constraintEnd_toEndOf="parent"/>
 
     <com.google.android.material.textfield.TextInputLayout
-        style="@style/TextInputLayoutBase"
         android:id="@+id/extra_input_layout"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_margin="8dp"
         android:hint="@string/crypto_extra_label"
-        app:hintEnabled="true"
         app:layout_constraintTop_toBottomOf="@id/generate_password"
         app:layout_constraintStart_toStartOf="parent">
 
diff --git a/app/src/main/res/layout/folder_creation_dialog_fragment.xml b/app/src/main/res/layout/folder_creation_dialog_fragment.xml
index dbaf97b3..375b4a30 100644
--- a/app/src/main/res/layout/folder_creation_dialog_fragment.xml
+++ b/app/src/main/res/layout/folder_creation_dialog_fragment.xml
@@ -11,9 +11,7 @@
         style="@style/TextInputLayoutBase"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:hint="@string/crypto_name_hint"
-        app:hintTextColor="@color/color_control_normal"
-        app:hintEnabled="true">
+        android:hint="@string/crypto_name_hint">
 
         <com.google.android.material.textfield.TextInputEditText
             android:id="@+id/folder_name_text"
diff --git a/app/src/main/res/layout/fragment_autofill.xml b/app/src/main/res/layout/fragment_autofill.xml
index e1a18696..29d0f517 100644
--- a/app/src/main/res/layout/fragment_autofill.xml
+++ b/app/src/main/res/layout/fragment_autofill.xml
@@ -14,8 +14,7 @@
     <com.google.android.material.textfield.TextInputLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:hint="URL"
-        app:hintEnabled="true">
+        android:hint="URL">
         <com.google.android.material.textfield.TextInputEditText
             android:id="@+id/webURL"
             android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/fragment_ssh_keygen.xml b/app/src/main/res/layout/fragment_ssh_keygen.xml
index cee878fd..16c3f512 100644
--- a/app/src/main/res/layout/fragment_ssh_keygen.xml
+++ b/app/src/main/res/layout/fragment_ssh_keygen.xml
@@ -24,12 +24,10 @@
             android:spinnerMode="dropdown" />
 
         <com.google.android.material.textfield.TextInputLayout
-            style="@style/TextInputLayoutBase"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginTop="8dp"
-            android:hint="@string/ssh_keygen_passphrase"
-            app:hintEnabled="true">
+            android:hint="@string/ssh_keygen_passphrase">
 
             <com.google.android.material.textfield.TextInputEditText
                 android:id="@+id/passphrase"
@@ -49,12 +47,10 @@
             android:text="@string/ssh_keygen_show_passphrase" />
 
         <com.google.android.material.textfield.TextInputLayout
-            style="@style/TextInputLayoutBase"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginTop="8dp"
-            android:hint="@string/ssh_keygen_comment"
-            app:hintEnabled="true">
+            android:hint="@string/ssh_keygen_comment">
 
             <com.google.android.material.textfield.TextInputEditText
                 android:id="@+id/comment"
-- 
cgit v1.2.3