From e5d178ea3ca29367593bfc92e8f95e17dcaba459 Mon Sep 17 00:00:00 2001 From: Fabian Henneke Date: Sun, 19 Apr 2020 10:40:49 +0200 Subject: Work around incompatibility between AndroidFastScroll and recyclerview-selection (#721) * Work around incompatibility between AndroidFastScroll and recyclerview-selection * move hacked recyclerview into separate package Signed-off-by: Harsh Shandilya * Make RecyclerViewHelper private static Co-authored-by: Harsh Shandilya --- app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'app/src/main/java/com/zeapo') diff --git a/app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt b/app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt index c9b9824f..eb97f1b8 100644 --- a/app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt +++ b/app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt @@ -17,8 +17,8 @@ import androidx.appcompat.view.ActionMode import androidx.fragment.app.Fragment import androidx.fragment.app.activityViewModels import androidx.lifecycle.observe +import androidx.recyclerview.widget.FixOnItemTouchDispatchRecyclerView import androidx.recyclerview.widget.LinearLayoutManager -import androidx.recyclerview.widget.RecyclerView import androidx.swiperefreshlayout.widget.SwipeRefreshLayout import com.google.android.material.floatingactionbutton.FloatingActionButton import com.google.android.material.snackbar.Snackbar @@ -35,7 +35,7 @@ import me.zhanghai.android.fastscroll.FastScrollerBuilder class PasswordFragment : Fragment() { private lateinit var recyclerAdapter: PasswordItemRecyclerAdapter - private lateinit var recyclerView: RecyclerView + private lateinit var recyclerView: FixOnItemTouchDispatchRecyclerView private lateinit var listener: OnFragmentInteractionListener private lateinit var swipeRefresher: SwipeRefreshLayout @@ -111,9 +111,6 @@ class PasswordFragment : Fragment() { adapter = recyclerAdapter } - // FastScrollerBuilder.build() needs to be called *before* recyclerAdapter.makeSelectable(), - // as otherwise dragging the fast scroller will lead to items being selected. - // See https://github.com/zhanghai/AndroidFastScroll/issues/13 FastScrollerBuilder(recyclerView).build() recyclerAdapter.makeSelectable(recyclerView) registerForContextMenu(recyclerView) -- cgit v1.2.3