From 2ffd1abb279bb0e1a8895ef26b805a1a1651516c Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Sun, 16 Aug 2020 02:16:02 +0530 Subject: Fix external storage UX (#1022) * build: update to Kotlin 1.4 Signed-off-by: Harsh Shandilya * UserPreference: finish if directory selection was triggered from an intent Signed-off-by: Harsh Shandilya * PasswordStore: switch permission request to ActivityResultContracts Signed-off-by: Harsh Shandilya * PasswordStore: fix activity reference Signed-off-by: Harsh Shandilya * GitOperationActivity: make invalid values more obvious Would have caught this issue much sooner if I had just done this Fixes: 3d8cea596600 ("Improve permission handling logic (#732)") Signed-off-by: Harsh Shandilya * Assorted collection of hackery to make external storage use palatable Signed-off-by: Harsh Shandilya * Update changelog Signed-off-by: Harsh Shandilya --- app/src/main/java/com/zeapo/pwdstore/utils/PasswordRepository.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/src/main/java/com/zeapo/pwdstore/utils') diff --git a/app/src/main/java/com/zeapo/pwdstore/utils/PasswordRepository.kt b/app/src/main/java/com/zeapo/pwdstore/utils/PasswordRepository.kt index 0a918d0c..8a49f0e3 100644 --- a/app/src/main/java/com/zeapo/pwdstore/utils/PasswordRepository.kt +++ b/app/src/main/java/com/zeapo/pwdstore/utils/PasswordRepository.kt @@ -169,7 +169,7 @@ open class PasswordRepository protected constructor() { val dir = getRepositoryDirectory() // uninitialize the repo if the dir does not exist or is absolutely empty settings.edit { - if (!dir.exists() || !dir.isDirectory || dir.listFiles()!!.isEmpty()) { + if (!dir.exists() || !dir.isDirectory || dir.listFiles()?.isEmpty() == true) { putBoolean(PreferenceKeys.REPOSITORY_INITIALIZED, false) } else { putBoolean(PreferenceKeys.REPOSITORY_INITIALIZED, true) -- cgit v1.2.3