From 5da9e67545644925902b04a11306289add29c033 Mon Sep 17 00:00:00 2001 From: Felix Bechstein Date: Tue, 25 Jul 2017 15:23:50 +0200 Subject: Fix lint warnings (#319) * Fix lint errors/warnings Fix a lot of lint errors and warnings. Most things are automatically applied fixes done with android studio: * externalize strings * remove unused code / classes / layouts / imports * migrate some fields to local variables * Remove dead code from comments Removed code that is commented out long ago. * remove unused resources * colors * strings * drawables * layouts * menus --- app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java') diff --git a/app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java b/app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java index 7d798a81..7b55dccf 100644 --- a/app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java +++ b/app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java @@ -103,7 +103,7 @@ public class pwgenDialogFragment extends DialogFragment { return ad; } - private boolean setPreferences () { + private void setPreferences () { ArrayList preferences = new ArrayList<>(); if (!((CheckBox) getDialog().findViewById(R.id.numerals)).isChecked()) { preferences.add("0"); @@ -123,9 +123,9 @@ public class pwgenDialogFragment extends DialogFragment { EditText editText = (EditText) getDialog().findViewById(R.id.lengthNumber); try { int length = Integer.valueOf(editText.getText().toString()); - return pwgen.setPrefs(getActivity().getApplicationContext(), preferences, length); + pwgen.setPrefs(getActivity().getApplicationContext(), preferences, length); } catch(NumberFormatException e) { - return pwgen.setPrefs(getActivity().getApplicationContext(), preferences); + pwgen.setPrefs(getActivity().getApplicationContext(), preferences); } } } -- cgit v1.2.3