From ec8bcae8fafa638e9e2e76ee041fa2db5bd292e6 Mon Sep 17 00:00:00 2001 From: Fabian Henneke Date: Tue, 14 Apr 2020 11:43:57 +0200 Subject: Improve Autofill enable UI and flaky browser list (#704) --- .../pwdstore/autofill/oreo/FeatureAndTrustDetection.kt | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'app/src/main/java/com/zeapo/pwdstore/autofill') diff --git a/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/FeatureAndTrustDetection.kt b/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/FeatureAndTrustDetection.kt index c268e755..be6263de 100644 --- a/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/FeatureAndTrustDetection.kt +++ b/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/FeatureAndTrustDetection.kt @@ -157,14 +157,18 @@ fun getBrowserAutofillSupportInfoIfTrusted( } private val FLAKY_BROWSERS = listOf( - "com.android.chrome" + "com.android.chrome", + "com.chrome.beta", + "com.chrome.canary", + "com.chrome.dev" ) enum class BrowserAutofillSupportLevel { None, FlakyFill, - Fill, - FillAndSave + PasswordFill, + GeneralFill, + GeneralFillAndSave } @RequiresApi(Build.VERSION_CODES.O) @@ -175,9 +179,10 @@ private fun getBrowserAutofillSupportLevel( val browserInfo = getBrowserAutofillSupportInfoIfTrusted(context, appPackage) return when { browserInfo == null -> BrowserAutofillSupportLevel.None - browserInfo.saveFlags != null -> BrowserAutofillSupportLevel.FillAndSave appPackage in FLAKY_BROWSERS -> BrowserAutofillSupportLevel.FlakyFill - else -> BrowserAutofillSupportLevel.Fill + browserInfo.multiOriginMethod == BrowserMultiOriginMethod.None -> BrowserAutofillSupportLevel.PasswordFill + browserInfo.saveFlags == null -> BrowserAutofillSupportLevel.GeneralFill + else -> BrowserAutofillSupportLevel.GeneralFillAndSave } } -- cgit v1.2.3