From 15665244fc13b410b476da1bd93561583d76eba9 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Wed, 27 May 2020 12:54:03 +0530 Subject: Resolve ViewBinding regressions (#799) * PasswordStore: remove broken snippet Signed-off-by: Harsh Shandilya * Cleanup code and remove incorrect onCreateView uses Signed-off-by: Harsh Shandilya * Fixup imports Signed-off-by: Harsh Shandilya --- .../com/zeapo/pwdstore/SelectFolderFragment.kt | 31 +++++++--------------- 1 file changed, 9 insertions(+), 22 deletions(-) (limited to 'app/src/main/java/com/zeapo/pwdstore/SelectFolderFragment.kt') diff --git a/app/src/main/java/com/zeapo/pwdstore/SelectFolderFragment.kt b/app/src/main/java/com/zeapo/pwdstore/SelectFolderFragment.kt index a17e6862..41c9443b 100644 --- a/app/src/main/java/com/zeapo/pwdstore/SelectFolderFragment.kt +++ b/app/src/main/java/com/zeapo/pwdstore/SelectFolderFragment.kt @@ -6,54 +6,41 @@ package com.zeapo.pwdstore import android.content.Context import android.os.Bundle -import android.view.LayoutInflater import android.view.View -import android.view.ViewGroup import androidx.appcompat.app.AppCompatActivity import androidx.fragment.app.Fragment import androidx.fragment.app.activityViewModels import androidx.lifecycle.observe import androidx.recyclerview.widget.LinearLayoutManager -import androidx.recyclerview.widget.RecyclerView -import com.google.android.material.floatingactionbutton.FloatingActionButton +import com.zeapo.pwdstore.databinding.PasswordRecyclerViewBinding import com.zeapo.pwdstore.ui.adapters.PasswordItemRecyclerAdapter import com.zeapo.pwdstore.utils.PasswordItem +import com.zeapo.pwdstore.utils.viewBinding import me.zhanghai.android.fastscroll.FastScrollerBuilder import java.io.File class SelectFolderFragment : Fragment() { + private val binding by viewBinding(PasswordRecyclerViewBinding::bind) private lateinit var recyclerAdapter: PasswordItemRecyclerAdapter - private lateinit var recyclerView: RecyclerView private lateinit var listener: OnFragmentInteractionListener private val model: SearchableRepositoryViewModel by activityViewModels() - override fun onCreateView( - inflater: LayoutInflater, - container: ViewGroup?, - savedInstanceState: Bundle? - ): View? { - val view = inflater.inflate(R.layout.password_recycler_view, container, false) - initializePasswordList(view) - val fab: FloatingActionButton = view.findViewById(R.id.fab) - fab.hide() - return view - } - - private fun initializePasswordList(rootView: View) { + override fun onViewCreated(view: View, savedInstanceState: Bundle?) { + super.onViewCreated(view, savedInstanceState) + binding.fab.hide() recyclerAdapter = PasswordItemRecyclerAdapter() .onItemClicked { _, item -> listener.onFragmentInteraction(item) } - recyclerView = rootView.findViewById(R.id.pass_recycler) - recyclerView.apply { + binding.passRecycler.apply { layoutManager = LinearLayoutManager(requireContext()) itemAnimator = null adapter = recyclerAdapter } - FastScrollerBuilder(recyclerView).build() - registerForContextMenu(recyclerView) + FastScrollerBuilder(binding.passRecycler).build() + registerForContextMenu(binding.passRecycler) val path = requireNotNull(requireArguments().getString(PasswordStore.REQUEST_ARG_PATH)) model.navigateTo(File(path), listMode = ListMode.DirectoriesOnly, pushPreviousLocation = false) -- cgit v1.2.3